Second attempt with new Repo: Rebasing .NET SDK To Version 1.31.1 With Instance Failover Group APIs#4259
Merged
shahabhijeet merged 7 commits intoAzure:SqlMgmt-CloudLifterfrom Apr 23, 2018
Conversation
shahabhijeet
suggested changes
Apr 23, 2018
Contributor
shahabhijeet
left a comment
There was a problem hiding this comment.
before pushing, at least build your project as below
msbuild build.proj /t:Build /p:Scope=SDKs\SqlManagement
shahabhijeet
approved these changes
Apr 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have rebased the .Net SDK to 1.13.1 by cherrypicking changes for InstanceFailoverGroup on top of the 1.13.0 branch.
The files are generated by targeting composite v2 APIs. Link to swagger template: ziwa-msft/azure-rest-api-specs@b2b5156
We have verified that all tests are passing locally.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.